-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add workflow for changelog #440
Merged
owaiskazi19
merged 3 commits into
opensearch-project:main
from
owaiskazi19:add-changelog
Jan 24, 2024
Merged
Add workflow for changelog #440
owaiskazi19
merged 3 commits into
opensearch-project:main
from
owaiskazi19:add-changelog
Jan 24, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Owais Kazi <[email protected]>
owaiskazi19
requested review from
dbwiddis,
joshpalis,
ohltyler,
amitgalitz and
jackiehanyang
as code owners
January 24, 2024 01:39
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #440 +/- ##
=========================================
Coverage 71.88% 71.88%
Complexity 620 620
=========================================
Files 78 78
Lines 3126 3126
Branches 236 236
=========================================
Hits 2247 2247
Misses 772 772
Partials 107 107 ☔ View full report in Codecov by Sentry. |
dbwiddis
reviewed
Jan 24, 2024
Signed-off-by: Owais Kazi <[email protected]>
dbwiddis
approved these changes
Jan 24, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, reserving the right to request changes later :)
joshpalis
approved these changes
Jan 24, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jan 24, 2024
* Add workflow for changelog Signed-off-by: Owais Kazi <[email protected]> * Addressed PR comments Signed-off-by: Owais Kazi <[email protected]> --------- Signed-off-by: Owais Kazi <[email protected]> (cherry picked from commit b84e9aa) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
owaiskazi19
pushed a commit
that referenced
this pull request
Jan 24, 2024
Add workflow for changelog (#440) * Add workflow for changelog * Addressed PR comments --------- (cherry picked from commit b84e9aa) Signed-off-by: Owais Kazi <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add workflow for changelog
Issues Resolved
Closes #437
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.